[luci] [PATCH] nixio HAS_SHADOW test link error

Bryan Mayland bmayland at leoninedev.com
Wed Aug 22 00:24:41 CEST 2012


I ran into an issue today where I noticed my nixio ended up not being 
built with shadow password support despite it being configured in 
OpenWrt (even after a make dirclean).  Because the test for HAS_SHADOW 
in the nixio Makefile uses the default CC flags, the test was being 
built with a different VFP abi than my cross-compiled libc so the test 
wouldn't link.

I'm not a master of the OpenWrt build system so I'm not sure if I should 
be changing the default gcc cflags, but just passing CFLAGS to the nixio 
shadow test also works

--- luci-trunk+svn8873/libs/nixio/Makefile.orig    2012-08-21 
18:14:04.914407195 -0400
+++ luci-trunk+svn8873/libs/nixio/Makefile    2012-08-21 
18:14:21.074631868 -0400
@@ -10,7 +10,7 @@
  AXTLS_DIR     = axTLS
  AXTLS_FILE    = $(AXTLS_DIR)-$(AXTLS_VERSION).tar.gz
  #NIXIO_TLS    ?= openssl
-NIXIO_SHADOW ?= $(shell echo 'int main(void){ return !getspnam("root"); 
}' | $(CC) -include shadow.h -xc -o/dev/null - 2>/dev/null && echo yes)
+NIXIO_SHADOW ?= $(shell echo 'int main(void){ return !getspnam("root"); 
}' | $(CC) $(CFLAGS) -include shadow.h -xc -o/dev/null - 2>/dev/null && 
echo yes)
  NIXIO_SO      = nixio.so
  NIXIO_LDFLAGS =




More information about the luci mailing list