[luci] Submitting Patch to Luci - CAPTCHA continues to reject

[Max B]

I've been attempting to submit a patch at:

http://luci.subsignal.org/trac/newticket

but it repeatedly tells me that I've entered the incorrect captcha input
(I've been at this for 15 min now - I'm pretty sure I got the captcha
correct at least a few times).


Here's the body of my ticket:


The main authenticator used by luci is called authenticator.htmlauth. It
is responsible for the "wrong username or password" page. It does not
check if the user is in the list of allowed users, but that is checked
later anyway and so the request is not allowed and no output is produced.




I've attached the patch here, but I've also just included it below:

Index: libs/web/luasrc/dispatcher.lua
===================================================================
--- libs/web/luasrc/dispatcher.lua      (revision 9957)
+++ libs/web/luasrc/dispatcher.lua      (working copy)
@@ -148,7 +148,7 @@
        local user = luci.http.formvalue("username")
        local pass = luci.http.formvalue("password")

-       if user and validator(user, pass) then
+       if user and validator(user, pass) and util.contains(accs, user) then
                return user
        end





Thanks a lot for your time and work!

Max
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dispatch_authenticator.patch
Type: text/x-patch
Size: 464 bytes
Desc: not available
URL: <http://lists.subsignal.org/pipermail/luci/attachments/20140302/5da05ad7/attachment.bin>