[luci] LuCId daemon explicit garbage collection

[Jo-Philipp Wich]

Am 21.07.11 17:49, schrieb Bryan Mayland:
> Oh man, I wasn't looking for a patch I just wanted to start a
> discussion about what was the right thing to do.

Sorry ;)

> 
> With this change, my instrumentation is showing that each child
> process inherits on average 300KB less (380KB vs 680KB) LUA state.

Thats good.

> Overall response times seem unchanged overall.  Serving a call() page
> that just returns a short string still takes ~310ms +/-20ms from
> accept() to data coming out.

Yeah, reducing the startup latency is on my todo, its been a while since
I profiled the stack.

> I grabbed a screen capture of a LUA state memory usage graph (shown
> in the bright green).  The oscillating pattern is before the change,
> going from 470KB to 890KB and the flat part a the end is after the
> change where it hovers around 380KB-390KB. 
> https://picasaweb.google.com/lh/photo/w3cJryIu6IwdcHzdGhWSsmagQEnRdXMcytaEIVOlUv8?feat=directlink

That
> 
looks very good.

> Is this being considered for inclusion in trunk?

Yes, I will push it to the repo as soon as I am at home.


Regards,
Jow